Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic when starting with dashboard v2 #2188

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

fuyufjh
Copy link
Contributor

@fuyufjh fuyufjh commented Apr 28, 2022

What's changed and what's your intention?

If you start risingwave playground via cargo run --bin risingwave -- playground with enable-dashboard-v2: true, it will panic and complain "environment variable not found". This PR fixes this.

Checklist

N/A

Refer to a related PR or issue link (optional)

None

@fuyufjh fuyufjh requested a review from skyzh April 28, 2022 04:18
@github-actions github-actions bot added the type/fix Bug fix label Apr 28, 2022
@skyzh
Copy link
Contributor

skyzh commented Apr 28, 2022

That's weird. The env variable is configured in risedevtool/common.toml 🤣

@fuyufjh
Copy link
Contributor Author

fuyufjh commented Apr 28, 2022

That's weird. The env variable is configured in risedevtool/common.toml 🤣

Yes, there's no problem if starting with risedev p, but

cargo run --bin risingwave -- playground

will fail. Any better solution?

@skyzh
Copy link
Contributor

skyzh commented Apr 28, 2022

That's weird. The env variable is configured in risedevtool/common.toml 🤣

Yes, there's no problem if starting with risedev p, but


cargo run --bin risingwave -- playground

will fail. Any better solution?

In this case, I think it's okay to get this PR merged.

@fuyufjh fuyufjh enabled auto-merge (squash) April 28, 2022 05:24
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #2188 (4c3b8c1) into main (a366da9) will increase coverage by 0.28%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2188      +/-   ##
==========================================
+ Coverage   70.58%   70.87%   +0.28%     
==========================================
  Files         650      650              
  Lines       82208    82344     +136     
==========================================
+ Hits        58030    58361     +331     
+ Misses      24178    23983     -195     
Flag Coverage Δ
rust 70.87% <0.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/risedevtool/src/task/meta_node_service.rs 0.00% <0.00%> (ø)
src/meta/src/cluster/mod.rs 59.39% <0.00%> (-0.26%) ⬇️
src/common/src/types/ordered_float.rs 24.10% <0.00%> (-0.20%) ⬇️
src/connector/src/filesystem/file_common.rs 80.88% <0.00%> (+0.88%) ⬆️
src/meta/src/manager/notification.rs 48.95% <0.00%> (+2.70%) ⬆️
src/frontend/src/scheduler/plan_fragmenter.rs 94.66% <0.00%> (+4.00%) ⬆️
src/frontend/src/scheduler/worker_node_manager.rs 79.45% <0.00%> (+9.58%) ⬆️
src/frontend/src/scheduler/execution/stage.rs 46.49% <0.00%> (+46.49%) ⬆️
src/frontend/src/scheduler/execution/query.rs 64.63% <0.00%> (+64.63%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@fuyufjh fuyufjh merged commit 7ddfa74 into main Apr 28, 2022
@fuyufjh fuyufjh deleted the eric/fix_crash_when_enabling_dashboard_v2 branch April 28, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants