-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(relational_layer): add value_meta in relational write interfaces #2194
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2194 +/- ##
==========================================
- Coverage 70.92% 70.90% -0.03%
==========================================
Files 650 650
Lines 82587 82642 +55
==========================================
+ Hits 58578 58600 +22
- Misses 24009 24042 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I think an alternative is to have an inner
method with a flag param indicating whether value meta needs computing, like:
fn batch_write_rows_inner(..., stateful_flag: bool) -> StorageResult<()> {
...
if stateful_flag {
// compute value meta
}
}
and call this inner method in batch_write_rows
and batch_write_rows_inner
to make the code clearer.
But since it is a storage write API, maybe we should put efficiency first and reduce unnecessary function call and |
I prefer reduce unnecessary |
Two small issues:
|
If you are interested, you may also refactor MaterializeExecutor to use distribution key for value meta. |
What's changed and what's your intention?
As title, relational layer provides hash and non-hash write interfaces.
Checklist
Refer to a related PR or issue link (optional)