Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmd): sets the default start up mode of compute node to `hu… #2201

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

BowenXiao1999
Copy link
Contributor

@BowenXiao1999 BowenXiao1999 commented Apr 28, 2022

…mmock+memory`

What's changed and what's your intention?

It is tested locally with ./risedev dev dev-compute-node.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title could better be chore(cmd).

@BowenXiao1999 BowenXiao1999 changed the title chore(risedev): sets the default start up mode of compute node to `hu… chore(cmd): sets the default start up mode of compute node to `hu… Apr 28, 2022
@BowenXiao1999 BowenXiao1999 enabled auto-merge (squash) April 28, 2022 08:22
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #2201 (5ef62db) into main (34e2e19) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2201   +/-   ##
=======================================
  Coverage   70.90%   70.90%           
=======================================
  Files         650      650           
  Lines       82704    82704           
=======================================
+ Hits        58641    58645    +4     
+ Misses      24063    24059    -4     
Flag Coverage Δ
rust 70.90% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/compute/src/lib.rs 2.85% <0.00%> (ø)
src/common/src/types/ordered_float.rs 24.30% <0.00%> (+0.19%) ⬆️
.../src/executor/managed_state/aggregation/extreme.rs 90.29% <0.00%> (+0.26%) ⬆️
src/connector/src/filesystem/file_common.rs 80.88% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BowenXiao1999 BowenXiao1999 merged commit 3e2ede4 into main Apr 28, 2022
@BowenXiao1999 BowenXiao1999 deleted the bw/switch-state-store-modes branch April 28, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants