Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reopen kafka basic tests #2207

Merged
merged 2 commits into from
Apr 28, 2022
Merged

ci: reopen kafka basic tests #2207

merged 2 commits into from
Apr 28, 2022

Conversation

tabVersion
Copy link
Contributor

Signed-off-by: tabVersion tabvision@bupt.icu

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

as title, use select * from s twice:

  1. trigger connector reader to fetch from kafka
  2. query from materialized source
  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
    • the test may last for 30s (on my local machine)
    • sleep 1s may not long enough for all reader to fetch data and it may cause unexpected failure

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: tabVersion <tabvision@bupt.icu>
@neverchanje neverchanje changed the title chore(ci): reopen kafka basic tests ci: reopen kafka basic tests Apr 28, 2022
Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

e2e_test/source/basic_test.slt Show resolved Hide resolved
Co-authored-by: Tao Wu <wutao@singularity-data.com>
@tabVersion tabVersion enabled auto-merge (squash) April 28, 2022 10:37
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #2207 (d9f3644) into main (61c645e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2207   +/-   ##
=======================================
  Coverage   70.92%   70.92%           
=======================================
  Files         650      650           
  Lines       82725    82725           
=======================================
  Hits        58671    58671           
  Misses      24054    24054           
Flag Coverage Δ
rust 70.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tabVersion tabVersion merged commit ec363e0 into main Apr 28, 2022
@tabVersion tabVersion deleted the tab/kafka-basic-test branch April 28, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants