Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(streaming): support create mv on index #2210

Merged
merged 5 commits into from
Apr 29, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Apr 28, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

What's changed and what's your intention?

This PR fixes several bugs and fully support create mv on index.

  • A separate struct to store arrangement info, so that lookup can work correctly.
  • Special case for chain. Need to set first barrier's prev epoch to 0. See comments for more information.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

ref #2016
may be blocked by #2151

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh
Copy link
Contributor Author

skyzh commented Apr 28, 2022

Unit test failed because of a new constraint is added, and should be fixed quickly. I'll continue to work on this tomorrow.

proto/stream_plan.proto Outdated Show resolved Hide resolved
src/stream/src/executor_v2/lookup.rs Show resolved Hide resolved
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh requested a review from yuhao-su April 29, 2022 02:09
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #2210 (0ccba27) into main (55cfc66) will decrease coverage by 0.06%.
The diff coverage is 24.19%.

@@            Coverage Diff             @@
##             main    #2210      +/-   ##
==========================================
- Coverage   70.94%   70.88%   -0.07%     
==========================================
  Files         657      657              
  Lines       83065    83134      +69     
==========================================
- Hits        58928    58927       -1     
- Misses      24137    24207      +70     
Flag Coverage Δ
rust 70.88% <24.19%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/catalog/physical_table.rs 0.00% <0.00%> (ø)
...c/meta/src/stream/fragmenter/rewrite/delta_join.rs 0.00% <0.00%> (ø)
src/stream/src/executor/mview/materialize.rs 0.00% <0.00%> (ø)
src/stream/src/executor_v2/lookup.rs 5.88% <0.00%> (+1.04%) ⬆️
...ntend/src/optimizer/plan_node/stream_delta_join.rs 48.57% <3.57%> (-18.85%) ⬇️
...c/meta/src/stream/fragmenter/graph/stream_graph.rs 64.35% <40.00%> (-0.62%) ⬇️
src/stream/src/executor_v2/lookup/impl_.rs 95.08% <76.19%> (-1.87%) ⬇️
...ontend/src/optimizer/plan_node/stream_hash_join.rs 67.92% <100.00%> (-2.52%) ⬇️
...rc/frontend/src/optimizer/rule/index_delta_join.rs 94.11% <100.00%> (-0.25%) ⬇️
...meta/src/stream/fragmenter/graph/fragment_graph.rs 97.14% <100.00%> (ø)
... and 7 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yuhao-su
Copy link
Contributor

LGTM!

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh enabled auto-merge (squash) April 29, 2022 05:14
@skyzh skyzh merged commit 0e094f7 into main Apr 29, 2022
@skyzh skyzh deleted the skyzh/create-mv-on-index branch April 29, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants