-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(streaming): support create mv on index #2210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Unit test failed because of a new constraint is added, and should be fixed quickly. I'll continue to work on this tomorrow. |
yuhao-su
reviewed
Apr 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #2210 +/- ##
==========================================
- Coverage 70.94% 70.88% -0.07%
==========================================
Files 657 657
Lines 83065 83134 +69
==========================================
- Hits 58928 58927 -1
- Misses 24137 24207 +70
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
yuhao-su
approved these changes
Apr 29, 2022
LGTM! |
…into skyzh/create-mv-on-index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Chi iskyzh@gmail.com
What's changed and what's your intention?
This PR fixes several bugs and fully support create mv on index.
Checklist
Refer to a related PR or issue link (optional)
ref #2016
may be blocked by #2151