-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(streaming): spin loop when too many row-id requests in single ms #2213
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2213 +/- ##
=======================================
Coverage 70.94% 70.94%
=======================================
Files 657 657
Lines 83065 83072 +7
=======================================
+ Hits 58928 58938 +10
+ Misses 24137 24134 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
In fact, I didn't think this really solves the problem. The clock can go forward or backward after the spin loop. So the next time we acquire an epoch, it might still be less than last generated one. |
Okay, maybe this PR doesn't take clock-go-backward into account. Then let's fix this altogether after monolithic clock has been implemented. |
This is just for row-id generate. Yes, clock-go-backward also need to be considered when compute node reboot. This will be fixed together with epoch. |
What's changed and what's your intention?
As title, after #2205.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
Refer to a related PR or issue link (optional)