Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): Use futures-async-stream to implement GenerateSeriesI32Executor executor #2218

Merged

Conversation

D2Lark
Copy link
Contributor

@D2Lark D2Lark commented Apr 29, 2022

Signed-off-by: d2lark lichengamoy@gmail.com

Implement GenerateSeriesI32Executor using Executor2 trait.

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #1934

Signed-off-by: d2lark <lichengamoy@gmail.com>
Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…executor2

Signed-off-by: TennyZhuang <zty0826@gmail.com>
@TennyZhuang
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #2218 (202d025) into main (511fffb) will increase coverage by 0.00%.
The diff coverage is 40.90%.

@@           Coverage Diff           @@
##             main    #2218   +/-   ##
=======================================
  Coverage   71.10%   71.10%           
=======================================
  Files         657      657           
  Lines       83880    83858   -22     
=======================================
- Hits        59643    59631   -12     
+ Misses      24237    24227   -10     
Flag Coverage Δ
rust 71.10% <40.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/mod.rs 60.46% <ø> (ø)
src/batch/src/executor2/mod.rs 100.00% <ø> (ø)
src/batch/src/executor2/generate_series.rs 68.85% <40.90%> (ø)
src/connector/src/filesystem/file_common.rs 80.88% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TennyZhuang TennyZhuang merged commit 68f34f3 into risingwavelabs:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use futures-async-stream to refactor GenerateSeriesI32Executor.
3 participants