Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): Use futures-async-stream to implement StreamScan executor #2232

Merged
merged 4 commits into from Apr 29, 2022

Conversation

D2Lark
Copy link
Contributor

@D2Lark D2Lark commented Apr 29, 2022

Signed-off-by: d2lark lichengamoy@gmail.com

Implement StreamScanExecutor using Executor2 trait

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #1944

Signed-off-by: d2lark <lichengamoy@gmail.com>
Copy link
Collaborator

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TennyZhuang
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #2232 (b8aacae) into main (14f8192) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2232   +/-   ##
=======================================
  Coverage   71.10%   71.10%           
=======================================
  Files         657      657           
  Lines       83860    83855    -5     
=======================================
  Hits        59626    59626           
+ Misses      24234    24229    -5     
Flag Coverage Δ
rust 71.10% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/mod.rs 60.46% <ø> (ø)
src/batch/src/executor2/mod.rs 100.00% <ø> (ø)
src/batch/src/executor2/stream_scan.rs 0.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TennyZhuang
Copy link
Collaborator

CI failed due to an unstable test and someone is working on fix it, please wait a moment.

@TennyZhuang
Copy link
Collaborator

Blocking by #2226

@TennyZhuang
Copy link
Collaborator

@D2Lark
Copy link
Contributor Author

D2Lark commented Apr 29, 2022

@TennyZhuang
Copy link
Collaborator

CI: https://github.com/singularity-data/risingwave/actions/runs/2244511049

my bad?

seems not, I will investigate on it

@TennyZhuang
Copy link
Collaborator

@TennyZhuang
Copy link
Collaborator

Thanks!

@TennyZhuang TennyZhuang merged commit aa947bc into risingwavelabs:main Apr 29, 2022
@D2Lark D2Lark deleted the impl_stream_scan_executor2 branch May 5, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use futures-async-stream to refactor StreamScanExecutor
4 participants