New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(batch): Use futures-async-stream to implement StreamScan executor #2232
refactor(batch): Use futures-async-stream to implement StreamScan executor #2232
Conversation
Signed-off-by: d2lark <lichengamoy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #2232 +/- ##
=======================================
Coverage 71.10% 71.10%
=======================================
Files 657 657
Lines 83860 83855 -5
=======================================
Hits 59626 59626
+ Misses 24234 24229 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
CI failed due to an unstable test and someone is working on fix it, please wait a moment. |
Blocking by #2226 |
seems not, I will investigate on it |
(rerun) CI is running: https://github.com/singularity-data/risingwave/actions/runs/2244749127 |
Thanks! |
Signed-off-by: d2lark lichengamoy@gmail.com
Implement StreamScanExecutor using Executor2 trait
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
Refer to a related PR or issue link (optional)
close #1944