Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): remove lifetime on Iter in StateStore #2235

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Apr 29, 2022

What's changed and what's your intention?

This is useless as we have removed all the lifetime on user iterators.

This is the first step for #2221 to replace scan with iter.

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #2235 (b9933bd) into main (08b2ec9) will decrease coverage by 0.08%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #2235      +/-   ##
==========================================
- Coverage   70.96%   70.88%   -0.09%     
==========================================
  Files         657      657              
  Lines       83050    83141      +91     
==========================================
- Hits        58938    58932       -6     
- Misses      24112    24209      +97     
Flag Coverage Δ
rust 70.88% <33.33%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/hummock/state_store.rs 71.93% <ø> (ø)
src/storage/src/memory.rs 80.00% <ø> (ø)
src/storage/src/monitor/monitored_store.rs 2.81% <0.00%> (ø)
src/storage/src/panic_store.rs 0.00% <ø> (ø)
src/storage/src/rocksdb_local_mock.rs 0.00% <ø> (ø)
src/storage/src/store.rs 100.00% <ø> (ø)
src/storage/src/tikv_mock.rs 0.00% <ø> (ø)
src/storage/src/keyspace.rs 90.17% <100.00%> (ø)
...ntend/src/optimizer/plan_node/stream_delta_join.rs 48.57% <0.00%> (-18.85%) ⬇️
src/connector/src/utils.rs 74.02% <0.00%> (-6.26%) ⬇️
... and 18 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lmatz lmatz enabled auto-merge (squash) April 29, 2022 07:37
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LONG EXPECTED!!!

@lmatz lmatz merged commit 20c355e into main Apr 29, 2022
@lmatz lmatz deleted the lz/iter branch April 29, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants