-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(state-store): fix a full key compare bug in state store get #2237
Conversation
676a47b
to
38364c2
Compare
&FullKey::from_slice(&table.key_range.as_ref().unwrap().left) | ||
.into_inner(), | ||
&FullKey::from_user_key_slice(key, epoch).into_inner(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still strange. We need to construct a FullKey and immediately consume it. A lot of copy here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have a FullKeySlice
structure here. https://github.com/dtolnay/ref-cast may help to convert &[u8] into a FullKeySlice
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it do not works. Refcast only accept one parameters like &[u8]. However, we get epoch and userkey (&[u8]). No idea how to concatenate them..
38364c2
to
0737796
Compare
0737796
to
323575f
Compare
Codecov Report
@@ Coverage Diff @@
## main #2237 +/- ##
==========================================
+ Coverage 70.88% 71.02% +0.14%
==========================================
Files 657 657
Lines 83141 83592 +451
==========================================
+ Hits 58936 59375 +439
- Misses 24205 24217 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
Refer to a related PR or issue link (optional)