Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(streaming): lookup barrier is not aligned #2244

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Apr 29, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

What's changed and what's your intention?

Lookup should forward barrier only when two sides are both ready.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #2243

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh requested a review from xxchan April 29, 2022 09:56
@github-actions github-actions bot added the type/fix Bug fix label Apr 29, 2022
@skyzh skyzh mentioned this pull request Apr 29, 2022
2 tasks
@skyzh skyzh enabled auto-merge (squash) April 29, 2022 10:01
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #2244 (d5ce477) into main (5c3a32e) will increase coverage by 0.06%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #2244      +/-   ##
==========================================
+ Coverage   71.03%   71.09%   +0.06%     
==========================================
  Files         657      657              
  Lines       83592    83865     +273     
==========================================
+ Hits        59378    59624     +246     
- Misses      24214    24241      +27     
Flag Coverage Δ
rust 71.09% <40.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor_v2/lookup/impl_.rs 95.08% <ø> (ø)
src/stream/src/executor_v2/lookup/sides.rs 29.16% <ø> (ø)
src/stream/src/executor/dispatch.rs 76.81% <37.50%> (-0.37%) ⬇️
src/stream/src/executor/actor.rs 87.09% <50.00%> (-6.24%) ⬇️
...rc/hummock/shared_buffer/shared_buffer_uploader.rs 81.73% <0.00%> (-5.77%) ⬇️
src/storage/src/hummock/shared_buffer/mod.rs 90.18% <0.00%> (-4.56%) ⬇️
src/frontend/src/expr/subquery.rs 46.42% <0.00%> (-1.85%) ⬇️
...e/src/hummock/shared_buffer/shared_buffer_batch.rs 94.16% <0.00%> (-1.47%) ⬇️
src/storage/src/hummock/mod.rs 85.54% <0.00%> (-1.37%) ⬇️
... and 17 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh merged commit df1ac5f into main Apr 29, 2022
@skyzh skyzh deleted the skyzh/fix-drop-index branch April 29, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

streaming: lookup executor doesn't correctly forward barriers
2 participants