Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pretty print key range in compaction task #2253

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Apr 29, 2022

close #2113

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #2253 (dbf5143) into main (511fffb) will decrease coverage by 0.01%.
The diff coverage is 23.52%.

@@            Coverage Diff             @@
##             main    #2253      +/-   ##
==========================================
- Coverage   71.10%   71.09%   -0.02%     
==========================================
  Files         657      657              
  Lines       83880    83893      +13     
==========================================
- Hits        59643    59641       -2     
- Misses      24237    24252      +15     
Flag Coverage Δ
rust 71.09% <23.52%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/hummock_sdk/src/compact.rs 68.00% <23.52%> (-32.00%) ⬇️
src/connector/src/filesystem/file_common.rs 80.88% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@hzxa21 hzxa21 merged commit 3c32741 into main Apr 29, 2022
@hzxa21 hzxa21 deleted the patrick/pretty-print-keyrange branch April 29, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change KeyRange to human readable strings in compaction task report
2 participants