refactor(frontend,streaming): separate output pk and internal key in topNExecutor #2258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
As #2130 suggests, the internal key used in
TopNExecutor
is different from the output primary key ofTopNExecutor
.This PR separates these two concepts.
Notice that as previously, the column used in both
order by
and primary keys will be deduplicated when used as the internal key. Only the backend, not the frontend, is now aware of this optimization.Checklist
Refer to a related PR or issue link (optional)
closes #2130
closes #2022