refactor(frontend): separate post-agg Project from LogicalAgg::create #2266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Post-agg Project from
select_items
(and post-agg Filter fromhaving
) will not be planned insideLogicalAgg::create
. This allows reusing the subquery expr handling logic inplan_select
. It will only createLogicalAgg
withagg_calls
extract fromselect_items
(andhaving
) and return the rewrittenselect_items
(andhaving
).Also reverts the unnecessary separation of
bind_select
andBoundSelect::create
in #2220 (comment)Checklist
- [ ] I have added necessary unit tests and integration tests(Refactor does not break existing tests.)Refer to a related PR or issue link (optional)