Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(binder): bind & plan insert #302

Merged
merged 6 commits into from Feb 15, 2022
Merged

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Feb 14, 2022

What's changed and what's your intention?

explain insert into t values (22, 33), (44, 55);

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #302 (11e978f) into main (d9ac2dc) will increase coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #302      +/-   ##
============================================
+ Coverage     74.22%   74.24%   +0.01%     
  Complexity     2668     2668              
============================================
  Files           856      859       +3     
  Lines         48535    48577      +42     
  Branches       1588     1588              
============================================
+ Hits          36027    36064      +37     
- Misses        11696    11701       +5     
  Partials        812      812              
Flag Coverage Δ
java 61.91% <ø> (ø)
rust 79.53% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/frontend/src/binder/mod.rs 100.00% <ø> (ø)
rust/frontend/src/planner/mod.rs 100.00% <ø> (ø)
rust/frontend/src/optimizer/plan_node/mod.rs 28.57% <50.00%> (+2.10%) ⬆️
...frontend/src/optimizer/plan_node/logical_insert.rs 57.14% <57.14%> (ø)
rust/frontend/src/binder/insert.rs 100.00% <100.00%> (ø)
rust/frontend/src/binder/statement.rs 83.33% <100.00%> (+8.33%) ⬆️
rust/frontend/src/handler/explain.rs 98.33% <100.00%> (+0.60%) ⬆️
rust/frontend/src/planner/insert.rs 100.00% <100.00%> (ø)
rust/frontend/src/planner/statement.rs 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9ac2dc...11e978f. Read the comment docs.

@xiangjinwu xiangjinwu marked this pull request as ready for review February 14, 2022 10:27
@xiangjinwu xiangjinwu merged commit afe52b3 into main Feb 15, 2022
@xiangjinwu xiangjinwu deleted the rust-frontend-binder-insert branch February 15, 2022 02:44
@BowenXiao1999 BowenXiao1999 mentioned this pull request Feb 15, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants