Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): add executor throughput and remove actor throughput #3045

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

MingjiHan99
Copy link
Contributor

@MingjiHan99 MingjiHan99 commented Jun 7, 2022

What's changed and what's your intention?

Remove actor_throughput metric and add executor_throughput metric.
Previous implementation of actor_throughput is incorrect.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#2938

@MingjiHan99 MingjiHan99 requested a review from skyzh June 7, 2022 17:16
@CLAassistant
Copy link

CLAassistant commented Jun 7, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/fix Bug fix label Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #3045 (783c0aa) into main (4f7206d) will decrease coverage by 0.00%.
The diff coverage is 27.77%.

@@            Coverage Diff             @@
##             main    #3045      +/-   ##
==========================================
- Coverage   73.49%   73.49%   -0.01%     
==========================================
  Files         733      733              
  Lines       99536    99548      +12     
==========================================
+ Hits        73157    73159       +2     
- Misses      26379    26389      +10     
Flag Coverage Δ
rust 73.49% <27.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/debug.rs 0.00% <0.00%> (ø)
src/stream/src/executor/debug/trace.rs 0.00% <ø> (ø)
src/stream/src/task/stream_manager.rs 0.00% <0.00%> (ø)
src/stream/src/executor/monitor/streaming_stats.rs 100.00% <100.00%> (ø)
src/storage/src/hummock/local_version_manager.rs 84.28% <0.00%> (+0.15%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 44.94% <0.00%> (+1.12%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

risedev.yml Outdated Show resolved Hide resolved
@MingjiHan99 MingjiHan99 requested a review from skyzh June 8, 2022 03:10
@skyzh
Copy link
Contributor

skyzh commented Jun 8, 2022

please resolve conflict and merge

@MingjiHan99 MingjiHan99 merged commit 97cb014 into main Jun 8, 2022
@MingjiHan99 MingjiHan99 deleted the executor_metrics branch June 8, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants