Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(relational_iter): dedup into_stream_inner and into_stream in StateTableRowIter #3057

Merged
merged 7 commits into from
Jun 9, 2022

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Jun 8, 2022

What's changed and what's your intention?

As title, using range of (Unbounded, Unbounded) for normal iter.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

close #3049

@wcy-fdu wcy-fdu marked this pull request as draft June 8, 2022 05:57
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3057 (4aae399) into main (9af55da) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4aae399 differs from pull request most recent head 132fa78. Consider uploading reports for the commit 132fa78 to get more accurate results

@@            Coverage Diff             @@
##             main    #3057      +/-   ##
==========================================
- Coverage   73.47%   73.46%   -0.01%     
==========================================
  Files         736      735       -1     
  Lines      100716   100477     -239     
==========================================
- Hits        73997    73816     -181     
+ Misses      26719    26661      -58     
Flag Coverage Δ
rust 73.46% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/table/state_table.rs 86.79% <100.00%> (ø)
src/storage/src/table/cell_based_table.rs 69.91% <0.00%> (-2.70%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 89.62% <0.00%> (-1.71%) ⬇️
src/storage/src/hummock/sstable/group_builder.rs 94.16% <0.00%> (-1.66%) ⬇️
src/meta/src/barrier/mod.rs 69.13% <0.00%> (-0.33%) ⬇️
src/meta/src/rpc/server.rs 0.00% <0.00%> (ø)
src/storage/src/keyspace.rs 87.62% <0.00%> (ø)
src/storage/src/hummock/mod.rs 85.52% <0.00%> (ø)
src/rpc_client/src/meta_client.rs 0.00% <0.00%> (ø)
src/meta/src/rpc/service/hummock_service.rs 0.00% <0.00%> (ø)
... and 5 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@wcy-fdu wcy-fdu marked this pull request as ready for review June 8, 2022 06:13
@wcy-fdu wcy-fdu requested a review from BugenZhao June 8, 2022 06:13
@wcy-fdu wcy-fdu changed the title refactor(relational_iter): dedup into_stream_inner and into_stream in StateTableRowIter refactor(relational_iter): dedup into_stream_inner and into_stream in StateTableRowIter Jun 8, 2022
@BugenZhao BugenZhao requested a review from skyzh June 8, 2022 06:52
skyzh
skyzh previously approved these changes Jun 8, 2022
Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3049 also raises an issue about bound.contains. We can do binary search to position the memtable iter instead of checking contains.

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Jun 9, 2022

Directly pass BTreeMap::Range to iterating mem_table to avoid doing a comparison every time when we meet a memtable key.

@skyzh skyzh enabled auto-merge (squash) June 9, 2022 07:30
@skyzh skyzh merged commit 25592cc into main Jun 9, 2022
@skyzh skyzh deleted the wcy_dedup_into_stream_inner branch June 9, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: dedup into_stream_inner and into_stream in StateTableRowIter
2 participants