-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(relational_iter): dedup into_stream_inner
and into_stream
in StateTableRowIter
#3057
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3057 +/- ##
==========================================
- Coverage 73.47% 73.46% -0.01%
==========================================
Files 736 735 -1
Lines 100716 100477 -239
==========================================
- Hits 73997 73816 -181
+ Misses 26719 26661 -58
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
…into wcy_dedup_into_stream_inner
into_stream_inner
and into_stream
in StateTableRowIter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3049 also raises an issue about bound.contains
. We can do binary search to position the memtable iter instead of checking contains.
Directly pass |
What's changed and what's your intention?
As title, using range of
(Unbounded, Unbounded)
for normal iter.Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)
close #3049