-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta): add compaction group service/client #3061
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3061 +/- ##
==========================================
- Coverage 73.47% 73.42% -0.06%
==========================================
Files 735 736 +1
Lines 100477 100552 +75
==========================================
- Hits 73827 73826 -1
- Misses 26650 26726 +76
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM.
pub async fn try_ger_compaction_group_id( | ||
&self, | ||
prefix: Prefix, | ||
) -> HummockResult<Option<CompactionGroupId>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return Option<CompactionGroupId>
instead?
What's changed and what's your intention?
Add
CompactionGroupClient
. It fetches and caches compaction group info from meta service.It will be used by both compute node and compactor node later.
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)
#2065