Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): add compaction group service/client #3061

Merged
merged 4 commits into from
Jun 9, 2022

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jun 8, 2022

What's changed and what's your intention?

Add CompactionGroupClient. It fetches and caches compaction group info from meta service.
It will be used by both compute node and compactor node later.

Checklist

  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#2065

@zwang28 zwang28 added component/meta Meta related issue. component/storage Storage labels Jun 8, 2022
@zwang28 zwang28 mentioned this pull request Jun 8, 2022
9 tasks
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3061 (ecfc526) into main (9ae9973) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3061      +/-   ##
==========================================
- Coverage   73.47%   73.42%   -0.06%     
==========================================
  Files         735      736       +1     
  Lines      100477   100552      +75     
==========================================
- Hits        73827    73826       -1     
- Misses      26650    26726      +76     
Flag Coverage Δ
rust 73.42% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/hummock/mock_hummock_meta_client.rs 42.39% <0.00%> (-1.43%) ⬇️
src/meta/src/rpc/server.rs 0.00% <0.00%> (ø)
src/meta/src/rpc/service/hummock_service.rs 0.00% <0.00%> (ø)
src/rpc_client/src/meta_client.rs 0.00% <0.00%> (ø)
src/storage/src/hummock/compaction_group_client.rs 0.00% <0.00%> (ø)
src/storage/src/hummock/hummock_meta_client.rs 0.00% <0.00%> (ø)
src/storage/src/hummock/mod.rs 85.52% <ø> (ø)
src/meta/src/barrier/mod.rs 69.13% <0.00%> (-0.33%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@zwang28 zwang28 marked this pull request as ready for review June 8, 2022 07:28
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

pub async fn try_ger_compaction_group_id(
&self,
prefix: Prefix,
) -> HummockResult<Option<CompactionGroupId>> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return Option<CompactionGroupId> instead?

@zwang28 zwang28 merged commit a283fed into main Jun 9, 2022
@zwang28 zwang28 deleted the wangzheng/compaction_group_service branch June 9, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants