-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: using barrier to initialize the source actor #3067
Conversation
9aa093d
to
000b243
Compare
Codecov Report
@@ Coverage Diff @@
## main #3067 +/- ##
==========================================
- Coverage 73.51% 73.50% -0.02%
==========================================
Files 732 732
Lines 99469 99526 +57
==========================================
+ Hits 73122 73153 +31
- Misses 26347 26373 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LSTM!!!
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
201944b
to
0deec99
Compare
What's changed and what's your intention?
This PR tries to use
Barrier
to initialize the Source Actor, replacing the original Protobuf fieldWhen the
create source
statement is executed, thesource_manager
spawns a loop coroutine to poll the source with the correspondingSplitEnumerator
and store the result in memory.At the end of
create materialized view
,stream_manager
executesrun_command(Command::CreateMaterializedView)
to generate anAddMutation
Barrier to initialize the entire DAG, and this PR tries to put the split initialization of the source actor into this Barrier.Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)