Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add combined SST builder #3075

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jun 8, 2022

What's changed and what's your intention?

Added CombinedGrouping strategy for GroupedSstableBuilder. It combines CompactionGroupGrouping and VirtualNodeGrouping. It will be used to group KVs by (compaction_group_id, parallel_unit_id).

Added tests for all KeyValueGroupingImpl.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#2065

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3075 (7421f36) into main (9ae9973) will increase coverage by 0.04%.
The diff coverage is 96.44%.

@@            Coverage Diff             @@
##             main    #3075      +/-   ##
==========================================
+ Coverage   73.47%   73.51%   +0.04%     
==========================================
  Files         735      735              
  Lines      100477   100651     +174     
==========================================
+ Hits        73827    73996     +169     
- Misses      26650    26655       +5     
Flag Coverage Δ
rust 73.51% <96.44%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/hummock/sstable/group_builder.rs 95.81% <96.44%> (+1.65%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@zwang28 zwang28 force-pushed the wangzheng/build_sst_with_compaction_group branch from e85e035 to 4da3295 Compare June 8, 2022 10:30
@zwang28 zwang28 marked this pull request as ready for review June 8, 2022 10:33
@zwang28 zwang28 added the component/storage Storage label Jun 8, 2022
@zwang28 zwang28 mentioned this pull request Jun 8, 2022
9 tasks
Copy link
Contributor

@soundOfDestiny soundOfDestiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correctness of code is trivial

@zwang28 zwang28 merged commit 9af55da into main Jun 9, 2022
@zwang28 zwang28 deleted the wangzheng/build_sst_with_compaction_group branch June 9, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants