Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot create a materialized view with struct column #3078

Merged
merged 11 commits into from
Jun 9, 2022

Conversation

cykbls01
Copy link
Contributor

@cykbls01 cykbls01 commented Jun 8, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Since field desc column not use as column, so we don't need field column desc have column id, remove the generate column id function to fix the problem.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#3055

@github-actions github-actions bot added the type/fix Bug fix label Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3078 (a8412a1) into main (0e313b1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3078      +/-   ##
==========================================
- Coverage   73.40%   73.40%   -0.01%     
==========================================
  Files         734      734              
  Lines       99973    99959      -14     
==========================================
- Hits        73388    73375      -13     
+ Misses      26585    26584       -1     
Flag Coverage Δ
rust 73.40% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/catalog/column_catalog.rs 91.66% <ø> (-1.20%) ⬇️
src/common/src/catalog/column.rs 79.44% <100.00%> (-0.45%) ⬇️
...tend/src/optimizer/plan_node/stream_materialize.rs 91.09% <100.00%> (-0.19%) ⬇️
src/meta/src/barrier/mod.rs 69.45% <0.00%> (+0.32%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@neverchanje
Copy link
Contributor

pls add some e2e tests

statement ok
create table t (v struct<a int>);

statement ok
create materialized view mv as select * from t;

query T
select * from mv;
----
1

@neverchanje neverchanje marked this pull request as ready for review June 9, 2022 01:27
@cykbls01 cykbls01 merged commit aae3f9c into main Jun 9, 2022
@cykbls01 cykbls01 deleted the fix/create_struct_mv branch June 9, 2022 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants