Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): cleanup after extreme null test #3079

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Jun 8, 2022

As per title.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@kwannoel kwannoel marked this pull request as ready for review June 8, 2022 11:34
@kwannoel kwannoel enabled auto-merge (squash) June 8, 2022 11:34
@github-actions github-actions bot added the type/fix Bug fix label Jun 8, 2022
@kwannoel kwannoel requested a review from neverchanje June 8, 2022 11:34
Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault, lgtm

@kwannoel kwannoel merged commit c3eca32 into main Jun 8, 2022
@kwannoel kwannoel deleted the kwannoel/fix-e2e branch June 8, 2022 11:46
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3079 (5b8d2dd) into main (bcb9ffa) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3079      +/-   ##
==========================================
- Coverage   73.50%   73.50%   -0.01%     
==========================================
  Files         732      732              
  Lines       99526    99526              
==========================================
- Hits        73155    73153       -2     
- Misses      26371    26373       +2     
Flag Coverage Δ
rust 73.50% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/hummock/mock_hummock_meta_client.rs 43.82% <0.00%> (-1.13%) ⬇️
src/storage/src/hummock/local_version_manager.rs 84.12% <0.00%> (-0.16%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants