Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(risedev): support prometheus + redpanda #3083

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jun 8, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

What's changed and what's your intention?

As title. Redpanda metrics are started with vectorized.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3083 (00c8ea8) into main (4f7206d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3083      +/-   ##
==========================================
- Coverage   73.49%   73.48%   -0.02%     
==========================================
  Files         733      733              
  Lines       99536    99552      +16     
==========================================
  Hits        73157    73157              
- Misses      26379    26395      +16     
Flag Coverage Δ
rust 73.48% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/risedevtool/src/compose.rs 0.00% <0.00%> (ø)
src/risedevtool/src/config_gen/prometheus_gen.rs 0.00% <0.00%> (ø)
src/risedevtool/src/service_config.rs 0.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh merged commit 337bf8e into main Jun 9, 2022
@skyzh skyzh deleted the skyzh/redpanda-prometheus branch June 9, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants