feat(streaming): apply StateTable to hash join #3085
Conversation
yuhao-su
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3085 +/- ##
=======================================
Coverage 73.22% 73.22%
=======================================
Files 747 747
Lines 101907 101907
=======================================
Hits 74619 74619
Misses 27288 27288
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
…sh_join_with_state_table
…sh_join_with_state_table
yuhao-su
requested review from
BowenXiao1999,
Enter-tainer,
jon-chuang,
skyzh,
TennyZhuang and
wcy-fdu
Need to fix #2794 or test fails. To do that we must have update. |
| /// Get an owned `Row` by the given `indices` from current row. | ||
| /// | ||
| /// Use `datum_refs_by_indices` if possible instead to avoid allocating owned datums. | ||
| pub fn by_indices(&self, indices: &[usize]) -> Row { |
There was a problem hiding this comment.
Off the topic: We should really review the current implementation of serialize functions. In most cases there's no need to allocate a Row.
| /// When evicted, `cached` does not hold any entries. | ||
| /// If a `JoinEntryState` exists for a join key, the all records under this | ||
| /// join key will be presented in the cache. | ||
| pub struct JoinEntryState { |
There was a problem hiding this comment.
Seems this struct is definitely a BTreeMap now. 🤣 How about implement Deref for it?
| let old_row = join_row.clone().into_row(); | ||
| join_row.inc_degree(); | ||
| let new_row = join_row.clone().into_row(); |
There was a problem hiding this comment.
This could be too costly. 😢 Let's optimize it later.
Yes! But I might keep changing the API anyway |
…sh_join_with_state_table
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
#2794
#2795