Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): remove redundant Result on serialize_pk #3088

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jun 9, 2022

What's changed and what's your intention?

as title

Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@xxchan xxchan changed the title chore: remove Result on serialize_pk chore(storage): remove Result on serialize_pk Jun 9, 2022
@xxchan xxchan changed the title chore(storage): remove Result on serialize_pk chore(storage): remove redundant Result on serialize_pk Jun 9, 2022
@xxchan xxchan enabled auto-merge (squash) June 9, 2022 02:44
@xxchan xxchan merged commit f90b137 into main Jun 9, 2022
@xxchan xxchan deleted the xxchan/p branch June 9, 2022 02:57
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #3088 (940082d) into main (77e07f0) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #3088      +/-   ##
==========================================
- Coverage   73.40%   73.40%   -0.01%     
==========================================
  Files         734      734              
  Lines       99959    99961       +2     
==========================================
- Hits        73376    73374       -2     
- Misses      26583    26587       +4     
Flag Coverage Δ
rust 73.40% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/table/cell_based_table.rs 72.61% <18.18%> (-0.36%) ⬇️
src/storage/src/table/state_table.rs 86.79% <66.66%> (-1.19%) ⬇️
src/common/src/util/ordered/serde.rs 91.06% <100.00%> (ø)
src/storage/src/table/test_relational_table.rs 98.21% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants