Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): cache artifacts in build image #3093

Merged
merged 9 commits into from
Jun 9, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jun 9, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

What's changed and what's your intention?

As title, still testing

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh marked this pull request as draft June 9, 2022 03:51
skyzh added 2 commits June 9, 2022 11:53
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh marked this pull request as ready for review June 9, 2022 04:30
@skyzh skyzh requested a review from huangjw806 June 9, 2022 04:30
skyzh added 5 commits June 9, 2022 12:32
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #3093 (5576a2c) into main (980e2cd) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 5576a2c differs from pull request most recent head 193049f. Consider uploading reports for the commit 193049f to get more accurate results

@@            Coverage Diff             @@
##             main    #3093      +/-   ##
==========================================
- Coverage   73.47%   73.47%   -0.01%     
==========================================
  Files         735      735              
  Lines      100446   100446              
==========================================
- Hits        73803    73802       -1     
- Misses      26643    26644       +1     
Flag Coverage Δ
rust 73.47% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/hummock/mock_hummock_meta_client.rs 43.82% <0.00%> (-1.13%) ⬇️
src/storage/src/hummock/local_version_manager.rs 84.12% <0.00%> (-0.16%) ⬇️
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@huangjw806
Copy link
Contributor

Great work!LGTM!

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh enabled auto-merge (squash) June 9, 2022 05:41
@skyzh skyzh merged commit 9ae9973 into main Jun 9, 2022
@skyzh skyzh deleted the skyzh/trivial-ci-cache branch June 9, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants