Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): ci upload failure logs #3099

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

huangjw806
Copy link
Contributor

@huangjw806 huangjw806 commented Jun 9, 2022

What's changed and what's your intention?

upload error logs after Buildkite CI command failed.

Checklist

- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests
- [ ] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

issue: #2898

Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It seems that build kite parsed the workflow in a wrong way? Why it turns out to be when: success? 🤣

post:
- when: failure
steps: |
- command: "cargo-make/makers logs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to run this command. If sqllogictest fails, logs are automatically stored in log folder. We simply need to upload them.

Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Better to name these files as:

risedev-logs/xxxx.log

Also in most cases, we'd download all the logs and browse them with VSCode. Maybe we can upload both the separate files (for quick preview in browser), and a zip containing all logs (for downloading locally and analyze).

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #3099 (d670f40) into main (68d81ab) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head d670f40 differs from pull request most recent head c9c6142. Consider uploading reports for the commit c9c6142 to get more accurate results

@@            Coverage Diff             @@
##             main    #3099      +/-   ##
==========================================
- Coverage   73.55%   73.47%   -0.08%     
==========================================
  Files         736      735       -1     
  Lines      101051   100477     -574     
==========================================
- Hits        74326    73828     -498     
+ Misses      26725    26649      -76     
Flag Coverage Δ
rust 73.47% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/hummock/compaction_group/mod.rs 55.55% <0.00%> (-38.89%) ⬇️
src/frontend/src/catalog/source_catalog.rs 60.86% <0.00%> (-7.56%) ⬇️
src/sqlparser/src/ast/statement.rs 78.18% <0.00%> (-3.19%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 89.62% <0.00%> (-1.71%) ⬇️
src/storage/src/hummock/sstable/group_builder.rs 94.16% <0.00%> (-1.66%) ⬇️
...frontend/src/optimizer/plan_node/logical_source.rs 66.12% <0.00%> (-1.57%) ⬇️
src/frontend/src/handler/mod.rs 63.52% <0.00%> (-1.25%) ⬇️
src/meta/src/stream/meta.rs 47.04% <0.00%> (-1.09%) ⬇️
...rontend/src/optimizer/plan_node/stream_exchange.rs 94.11% <0.00%> (-0.76%) ⬇️
...rc/storage/hummock_sdk/src/compaction_group/mod.rs 64.70% <0.00%> (-0.68%) ⬇️
... and 37 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@huangjw806 huangjw806 force-pushed the huangjw/ci-upload-failure-logs branch 2 times, most recently from 969ff49 to b352e8c Compare June 9, 2022 10:18
@huangjw806 huangjw806 changed the title upload failure logs chore(ci): ci upload failure logs Jun 9, 2022
upload error logs after Buildkite CI command failed.
@huangjw806 huangjw806 force-pushed the huangjw/ci-upload-failure-logs branch from b352e8c to c9c6142 Compare June 9, 2022 10:29
@huangjw806 huangjw806 marked this pull request as ready for review June 9, 2022 10:40
@huangjw806 huangjw806 merged commit 93a5670 into main Jun 9, 2022
@huangjw806 huangjw806 deleted the huangjw/ci-upload-failure-logs branch June 9, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants