-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): ci upload failure logs #3099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci/workflows/pull-request.yml
Outdated
post: | ||
- when: failure | ||
steps: | | ||
- command: "cargo-make/makers logs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to run this command. If sqllogictest fails, logs are automatically stored in log folder. We simply need to upload them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## main #3099 +/- ##
==========================================
- Coverage 73.55% 73.47% -0.08%
==========================================
Files 736 735 -1
Lines 101051 100477 -574
==========================================
- Hits 74326 73828 -498
+ Misses 26725 26649 -76
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
969ff49
to
b352e8c
Compare
upload error logs after Buildkite CI command failed.
b352e8c
to
c9c6142
Compare
What's changed and what's your intention?
upload error logs after Buildkite CI command failed.
Checklist
- [ ] I have written necessary docs and comments- [ ] I have added necessary unit tests and integration tests- [ ] All checks passed in./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)
issue: #2898