Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connector): simplify pulsar reader #3103

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Jun 9, 2022

Signed-off-by: Peng Chen peng@singularity-data.com

What's changed and what's your intention?

as title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #3103 (350fb1a) into main (f5c62f8) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3103      +/-   ##
==========================================
+ Coverage   73.48%   73.50%   +0.02%     
==========================================
  Files         734      734              
  Lines      100207   100175      -32     
==========================================
  Hits        73633    73633              
+ Misses      26574    26542      -32     
Flag Coverage Δ
rust 73.50% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connector/src/pulsar/source/reader.rs 0.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lets fix pulsar client later

@shanicky shanicky merged commit 68d81ab into main Jun 9, 2022
@shanicky shanicky deleted the peng/simplify-pulsar branch June 9, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants