refactor(state_table): remove pk in state_table insert_row/delete_row #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3107 +/- ##
==========================================
- Coverage 73.57% 73.49% -0.08%
==========================================
Files 745 745
Lines 102240 101952 -288
==========================================
- Hits 75223 74930 -293
- Misses 27017 27022 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
BowenXiao1999
approved these changes
Jun 14, 2022
src/storage/src/table/state_table.rs
Outdated
Comment on lines
137
to
139
| let cell_based_start_key = Included(self.keyspace.key().to_vec()); | ||
| let cell_based_end_key = Excluded(next_key(self.keyspace.key())); | ||
| let cell_based_bounds = (cell_based_start_key, cell_based_end_key); |
There was a problem hiding this comment.
Was this be fixed in another PR?
There was a problem hiding this comment.
The former is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
As title.
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)