Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create mv support array expression #3113

Merged
merged 4 commits into from
Jun 10, 2022
Merged

fix: create mv support array expression #3113

merged 4 commits into from
Jun 10, 2022

Conversation

cykbls01
Copy link
Contributor

@cykbls01 cykbls01 commented Jun 9, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

create materialized view mv as select min(v1) as m from lt;

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/fix Bug fix label Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #3113 (687adf3) into main (4770ec6) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3113      +/-   ##
==========================================
- Coverage   73.54%   73.53%   -0.02%     
==========================================
  Files         736      736              
  Lines      101680   101698      +18     
==========================================
- Hits        74782    74781       -1     
- Misses      26898    26917      +19     
Flag Coverage Δ
rust 73.53% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/mod.rs 67.68% <0.00%> (-0.93%) ⬇️
src/utils/memcomparable/src/de.rs 88.70% <0.00%> (-0.83%) ⬇️
src/utils/memcomparable/src/ser.rs 93.62% <0.00%> (-0.76%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@cykbls01 cykbls01 closed this Jun 9, 2022
@cykbls01 cykbls01 reopened this Jun 9, 2022
@cykbls01 cykbls01 marked this pull request as ready for review June 10, 2022 11:02
@cykbls01 cykbls01 merged commit cbd7404 into main Jun 10, 2022
@cykbls01 cykbls01 deleted the fix/create_mv_array branch June 10, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants