Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compaction): fix compaction task do not schedule even if the number of L0 files is very large #3117

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

Little-Wallace
Copy link
Contributor

@Little-Wallace Little-Wallace commented Jun 10, 2022

Signed-off-by: Little-Wallace bupt2013211450@gmail.com

What's changed and what's your intention?

close #3066

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@github-actions github-actions bot added the type/fix Bug fix label Jun 10, 2022
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for the PR!

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #3117 (724d3f8) into main (4ffe791) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3117   +/-   ##
=======================================
  Coverage   73.62%   73.63%           
=======================================
  Files         736      736           
  Lines      101467   101508   +41     
=======================================
+ Hits        74701    74741   +40     
- Misses      26766    26767    +1     
Flag Coverage Δ
rust 73.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/src/hummock/compaction/tier_compaction_picker.rs 96.64% <100.00%> (+0.22%) ⬆️
src/meta/src/barrier/mod.rs 69.13% <0.00%> (-0.33%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh
Copy link
Contributor

skyzh commented Jun 10, 2022

merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compaction: meta-service would not schedule a new compaction-task
3 participants