fix(optimizer): fix lost projection pk

[skyzh]

Signed-off-by: Alex Chi iskyzh@gmail.com

What's changed and what's your intention?

The original implementation of projection pk selection seems wrong -- if any key is filtered from pk, then all pks are lost.

Note that this PR still doesn't solve .#3118

Checklist

• I have written necessary docs and comments
• I have added necessary unit tests and integration tests
• All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

close #3086

[codecov]

Codecov Report

Merging #3119 (964e1b3) into main (9a34de4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3119      +/-   ##
==========================================
- Coverage   73.63%   73.63%   -0.01%     
==========================================
  Files         736      736              
  Lines      101546   101545       -1     
==========================================
- Hits        74776    74774       -2     
- Misses      26770    26771       +1     

Flag	Coverage Δ
rust	73.63% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rontend/src/optimizer/plan_node/logical_project.rs	98.93% <100.00%> (-0.01%)	⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs	42.39% <0.00%> (-1.09%)	⬇️
src/storage/src/hummock/local_version_manager.rs	84.12% <0.00%> (-0.16%)	⬇️
src/meta/src/barrier/mod.rs	69.45% <0.00%> (+0.32%)	⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[st1page]

sorry for the late reply

if any key is filtered from pk, then all pks are lost

I think we should do that... we need we can identify a row with the pks. so if a key is removed by projection, then we can not give any pk of the result. for example if there is a table(a,b,c) with pk(a,b) and rows(1,2,3), (1,3,3), and we do projection to remove the second column, then the result is rows (1,3), (1,3). there is no pk for the result.