Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): use CompactionConfigBuilder #3128

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jun 10, 2022

What's changed and what's your intention?

Fix incorrect usage of CompactionConfig::default.
Should use CompactionConfigBuilder.

Temporarily disable StateCleanUpCompactionFilter, because compaction group manager is not providing the correct existing_table_ids in 9a34de4.

Checklist

  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/fix Bug fix label Jun 10, 2022
@zwang28 zwang28 enabled auto-merge (squash) June 10, 2022 08:54
@zwang28 zwang28 changed the title fix(meta): use CompactionConfigBuilder builder fix(meta): use CompactionConfigBuilder Jun 10, 2022
@zwang28 zwang28 disabled auto-merge June 10, 2022 08:54
@zwang28 zwang28 enabled auto-merge (squash) June 10, 2022 08:54
@zwang28 zwang28 disabled auto-merge June 10, 2022 08:55
@zwang28 zwang28 marked this pull request as draft June 10, 2022 08:57
Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGM

@zwang28 zwang28 marked this pull request as ready for review June 10, 2022 09:52
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #3128 (3b633d1) into main (ea9612c) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
- Coverage   73.75%   73.54%   -0.21%     
==========================================
  Files         736      736              
  Lines      101680   101680              
==========================================
- Hits        74992    74782     -210     
- Misses      26688    26898     +210     
Flag Coverage Δ
rust 73.54% <100.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/hummock/compactor_tests.rs 35.88% <ø> (-56.10%) ⬇️
src/meta/src/hummock/compaction_group/manager.rs 92.43% <100.00%> (ø)
src/storage/src/hummock/compactor.rs 71.24% <100.00%> (-2.37%) ⬇️
src/storage/src/hummock/state_store.rs 77.53% <0.00%> (-7.70%) ⬇️
src/meta/src/hummock/compaction/mod.rs 79.76% <0.00%> (-2.32%) ⬇️
src/storage/src/hummock/mod.rs 84.21% <0.00%> (-1.32%) ⬇️
src/storage/src/hummock/utils.rs 93.18% <0.00%> (-1.14%) ⬇️
src/meta/src/model/mod.rs 98.10% <0.00%> (-0.64%) ⬇️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@zwang28 zwang28 merged commit 4770ec6 into main Jun 10, 2022
@zwang28 zwang28 deleted the wangzheng/fix_wrong_default_config branch June 10, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants