feat(meta): separate inject_barrier_RPC and collect_over_RPC

[xxhZs]

What's changed and what's your intention?

We separate inject_barrier_RPC and barrier_complete_RPC.
Previously, When we inject barrier to CN, the RPC did not return until all collection tasks were complete.
Now , the inject_barrier_RPC can return when we send barrier to all source actor, then barrier_manager will send barrier_complete_RPC to CN wait collection.

In concurrent checkpoint, We need source to send the barrier in order. So we separate inject_barrier_RPC and barrier_complete_RPC. We can inject barrier with single thread to ensure orderly, and concurrently wait for the collection.

Checklist

• I have written necessary docs and comments
• I have added necessary unit tests and integration tests
• All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#2184

[BugenZhao]

This implementation seems to make the barrier stuffs much more complicated and harder to read. I'm also wondering if this is really necessary for concurrent checkpoints. Let's have an offline talk on weekdays.

[codecov]

Codecov Report

Merging #3129 (0177c74) into main (bdac332) will decrease coverage by 0.00%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##             main    #3129      +/-   ##
==========================================
- Coverage   73.59%   73.59%   -0.01%     
==========================================
  Files         744      744              
  Lines      102029   102080      +51     
==========================================
+ Hits        75092    75126      +34     
- Misses      26937    26954      +17     

Flag	Coverage Δ
rust	73.59% <53.84%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/compute/src/rpc/service/stream_service.rs	0.00% <0.00%> (ø)
src/meta/src/barrier/progress.rs	17.39% <ø> (ø)
src/meta/src/barrier/recovery.rs	0.00% <ø> (ø)
src/rpc_client/src/meta_client.rs	0.00% <0.00%> (ø)
...c/stream/src/task/barrier_manager/managed_state.rs	78.51% <ø> (ø)
src/stream/src/task/env.rs	0.00% <ø> (ø)
src/stream/src/task/stream_manager.rs	0.00% <0.00%> (ø)
src/stream/src/task/barrier_manager.rs	70.52% <75.00%> (+0.15%)	⬆️
src/meta/src/barrier/mod.rs	69.94% <83.33%> (+0.48%)	⬆️
src/meta/src/stream/stream_manager.rs	69.20% <100.00%> (+0.30%)	⬆️
... and 5 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[hzxa21]

The code looks cleaner now. Good job.

[BugenZhao]

Much clearer now! Generally in the right way.

[BugenZhao]

Rest LGTM.

[BugenZhao]

LGTM. Great job!