Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hummock): remove combine group for compaction #3138

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

Little-Wallace
Copy link
Contributor

@Little-Wallace Little-Wallace commented Jun 10, 2022

Signed-off-by: Little-Wallace bupt2013211450@gmail.com

What's changed and what's your intention?

  • remove CombinedGrouping. I have talked with @zwang28. We will split all get/write/flush operations for different group. Of course, the sst files of different group will be also splitted.
  • add unit id for sstableinfo for unit aware compaction. See more details in feat(compaction): support sub-level in L0  #3111

Checklist

  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #3138 (3459beb) into main (86c7df1) will decrease coverage by 0.01%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##             main    #3138      +/-   ##
==========================================
- Coverage   73.64%   73.63%   -0.02%     
==========================================
  Files         736      736              
  Lines      101586   101514      -72     
==========================================
- Hits        74814    74745      -69     
+ Misses      26772    26769       -3     
Flag Coverage Δ
rust 73.63% <95.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/hummock/sstable/multi_builder.rs 91.09% <80.00%> (+0.04%) ⬆️
...a/src/hummock/compaction/tier_compaction_picker.rs 96.64% <100.00%> (+<0.01%) ⬆️
src/meta/src/hummock/test_utils.rs 95.62% <100.00%> (+0.02%) ⬆️
src/storage/src/hummock/compactor.rs 73.74% <100.00%> (+0.12%) ⬆️
...rc/hummock/shared_buffer/shared_buffer_uploader.rs 87.50% <100.00%> (+0.09%) ⬆️
src/storage/src/hummock/sstable/builder.rs 91.62% <100.00%> (+0.09%) ⬆️
src/storage/src/hummock/sstable/group_builder.rs 95.59% <100.00%> (-0.23%) ⬇️
src/storage/src/hummock/sstable/mod.rs 96.85% <100.00%> (+0.01%) ⬆️
src/storage/src/hummock/test_utils.rs 86.13% <100.00%> (+0.20%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@zwang28 zwang28 self-requested a review June 13, 2022 04:10
@Little-Wallace Little-Wallace merged commit 8286446 into main Jun 13, 2022
@Little-Wallace Little-Wallace deleted the wallace/refactor branch June 13, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants