Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): re-enable compaction filter #3141

Merged
merged 9 commits into from
Jun 13, 2022

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jun 11, 2022

What's changed and what's your intention?

Workaround compaction filter failure due to unfinished compaction group feature.
Re-enable compaction filter.

Checklist

  • I have written necessary docs and comments
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@zwang28 zwang28 requested a review from Li0k June 11, 2022 05:42
@github-actions github-actions bot added the type/fix Bug fix label Jun 11, 2022
@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #3141 (fc7dd70) into main (36cf71f) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3141      +/-   ##
==========================================
+ Coverage   73.54%   73.75%   +0.20%     
==========================================
  Files         739      739              
  Lines      101804   101807       +3     
==========================================
+ Hits        74873    75086     +213     
+ Misses      26931    26721     -210     
Flag Coverage Δ
rust 73.75% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/hummock/compactor_tests.rs 91.98% <ø> (+56.09%) ⬆️
src/meta/src/hummock/compaction_group/manager.rs 92.51% <100.00%> (+0.07%) ⬆️
src/storage/src/hummock/compactor.rs 73.74% <100.00%> (+2.35%) ⬆️
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️
src/storage/src/hummock/conflict_detector.rs 96.51% <0.00%> (+0.49%) ⬆️
src/meta/src/model/mod.rs 98.73% <0.00%> (+0.63%) ⬆️
src/storage/src/hummock/utils.rs 94.31% <0.00%> (+1.13%) ⬆️
src/storage/src/hummock/mod.rs 85.52% <0.00%> (+1.31%) ⬆️
src/meta/src/hummock/compaction/mod.rs 81.50% <0.00%> (+1.73%) ⬆️
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zwang28 zwang28 merged commit 4b58d27 into main Jun 13, 2022
@zwang28 zwang28 deleted the wangzheng/fix_compaction_filter branch June 13, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants