Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): deprecate in-memory state store in e2e scenarios #3153

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

BugenZhao
Copy link
Member

Signed-off-by: Bugen Zhao i@bugenzhao.com

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

src/risedevtool/src/task/compute_node_service.rs Outdated Show resolved Hide resolved
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao force-pushed the bz/deprecate-in-memory-state-store branch from 2c1c55f to cff6604 Compare June 13, 2022 03:54
@BugenZhao BugenZhao enabled auto-merge (squash) June 13, 2022 03:56
@BugenZhao BugenZhao merged commit ce23e4a into main Jun 13, 2022
@BugenZhao BugenZhao deleted the bz/deprecate-in-memory-state-store branch June 13, 2022 04:15
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3153 (a85b8d0) into main (32aaae0) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3153      +/-   ##
==========================================
+ Coverage   73.51%   73.52%   +0.01%     
==========================================
  Files         738      738              
  Lines      101668   101657      -11     
==========================================
+ Hits        74743    74746       +3     
+ Misses      26925    26911      -14     
Flag Coverage Δ
rust 73.52% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/risedevtool/src/service_config.rs 0.00% <ø> (ø)
src/risedevtool/src/task/compactor_service.rs 0.00% <0.00%> (ø)
src/risedevtool/src/task/compute_node_service.rs 0.00% <0.00%> (ø)
src/risedevtool/src/task/utils.rs 0.00% <0.00%> (ø)
src/storage/src/store_impl.rs 8.00% <0.00%> (+0.15%) ⬆️
src/storage/src/hummock/local_version_manager.rs 84.28% <0.00%> (+0.15%) ⬆️
src/meta/src/barrier/mod.rs 69.45% <0.00%> (+0.32%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 43.47% <0.00%> (+1.08%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

BugenZhao added a commit that referenced this pull request Aug 26, 2022
…ios (#3153)"

This reverts commit ce23e4a.

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
mergify bot pushed a commit that referenced this pull request Sep 15, 2022
#5322)

* Revert "chore(storage): deprecate in-memory state store in e2e scenarios (#3153)"

This reverts commit ce23e4a.

Signed-off-by: Bugen Zhao <i@bugenzhao.com>

* batched iterator

Signed-off-by: Bugen Zhao <i@bugenzhao.com>

* add more docs

Signed-off-by: Bugen Zhao <i@bugenzhao.com>

* add to workflows

Signed-off-by: Bugen Zhao <i@bugenzhao.com>

* add unit tests

Signed-off-by: Bugen Zhao <i@bugenzhao.com>

* refine docs

Signed-off-by: Bugen Zhao <i@bugenzhao.com>

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: deprecate --state-store in-memory
4 participants