Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add some real-world use cases to e2e testing #3158

Merged
merged 5 commits into from
Jun 13, 2022
Merged

Conversation

neverchanje
Copy link
Contributor

@neverchanje neverchanje commented Jun 13, 2022

What's changed and what's your intention?

This pr is to ensure some sql that were used by our blogs or some other use cases will not be broken on the main branch.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@neverchanje neverchanje changed the title test: add some real-world use cases test: add some real-world use cases to e2e testing Jun 13, 2022
@github-actions github-actions bot added the component/test Test related issue. label Jun 13, 2022
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3158 (b0e0a6b) into main (dc2a9ef) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head b0e0a6b differs from pull request most recent head 169bf87. Consider uploading reports for the commit 169bf87 to get more accurate results

@@            Coverage Diff             @@
##             main    #3158      +/-   ##
==========================================
- Coverage   73.54%   73.50%   -0.04%     
==========================================
  Files         739      738       -1     
  Lines      101807   101585     -222     
==========================================
- Hits        74875    74674     -201     
+ Misses      26932    26911      -21     
Flag Coverage Δ
rust 73.50% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/expr/src/vector_op/agg/approx_count_distinct.rs 84.10% <0.00%> (-3.74%) ⬇️
src/stream/src/executor/aggregation/mod.rs 94.96% <0.00%> (ø)
.../src/executor/aggregation/approx_count_distinct.rs
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh
Copy link
Contributor

skyzh commented Jun 13, 2022

main currently is broken. Let's merge later.

@skyzh skyzh enabled auto-merge (squash) June 13, 2022 07:22
@skyzh skyzh merged commit c4b56bd into main Jun 13, 2022
@skyzh skyzh deleted the wt-array-access branch June 13, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants