-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stream): introduce relational top_n #3160
Conversation
…-data/risingwave into wcy_refactor_top_n
…into wcy_refactor_top_n
Codecov Report
@@ Coverage Diff @@
## main #3160 +/- ##
==========================================
- Coverage 73.55% 73.51% -0.04%
==========================================
Files 745 744 -1
Lines 101501 101354 -147
==========================================
- Hits 74659 74514 -145
+ Misses 26842 26840 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What's changed and what's your intention?
This PR Implements the read/write of TopN executor by state table, which removed
flush_buffer
intop_n_state
andtop_n_bottom_n_state
.Since top_n has implemented a merge logic of flush_buffer and storage named
scan_and_merge
, I just refactor it and rename toscan from relational_table
(Or we can change it to something more appropriate).Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)
close #1206