feat(pgwire): add infer_return_type interface in session trait #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
changed the title
src/utils/pgwire/src/pg_protocol.rs
Outdated
Comment on lines
176
to
198
| let rows: Vec<PgFieldDescriptor> = query | ||
| .split(&[' ', ',', ';']) | ||
| .skip(1) | ||
| .into_iter() | ||
| .map(|x| { | ||
| if let Some(str) = x.strip_prefix('$') { | ||
| if let Ok(i) = str.parse() { | ||
| i | ||
| } else { | ||
| -1 | ||
| } | ||
| } else { | ||
| -1 | ||
| } | ||
| }) | ||
| .take_while(|x: &i32| x.is_positive()) | ||
| .map(|x| { | ||
| // NOTE Make sure the type_description include all generic parametre | ||
| // description we needed. | ||
| assert!((x.sub(1) as usize) < types.len()); | ||
| PgFieldDescriptor::new(String::new(), types[x.sub(1) as usize].to_owned()) | ||
| }) | ||
| .collect(); |
There was a problem hiding this comment.
Why these part of logic looks so complicated while the impl in Session is so short...
There was a problem hiding this comment.
Because the original implement needs to infer the row description from the types descriptions. Now, We just simply get the row description from the infer_return_type. The complicated parts are left to the implementation of infer_return_type.
Codecov Report
@@ Coverage Diff @@
## main #3161 +/- ##
==========================================
- Coverage 73.50% 73.49% -0.01%
==========================================
Files 746 746
Lines 101925 101981 +56
==========================================
+ Hits 74916 74951 +35
- Misses 27009 27030 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
ZENOTME
force-pushed
the
zj/add_pgwire_infer_return_type
branch
from
5bf3193
to
486945e
Compare
BowenXiao1999
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
#3131