Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(metrics): move some metrics from meta to compactor #3164

Merged
merged 4 commits into from
Jun 13, 2022

Conversation

Little-Wallace
Copy link
Contributor

@Little-Wallace Little-Wallace commented Jun 13, 2022

Signed-off-by: Little-Wallace bupt2013211450@gmail.com

What's changed and what's your intention?

It's not necessary to collect all metrics info from compactor to meta

  • remove metrics in compact_task and report them in compactor directly.
  • change level metrics to speed for better observation.

image

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Blind +1.

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3164 (fcbe8fb) into main (8286446) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3164      +/-   ##
==========================================
- Coverage   73.50%   73.48%   -0.03%     
==========================================
  Files         738      738              
  Lines      101585   101481     -104     
==========================================
- Hits        74674    74577      -97     
+ Misses      26911    26904       -7     
Flag Coverage Δ
rust 73.48% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/hummock/compaction/mod.rs 77.41% <ø> (-2.35%) ⬇️
src/meta/src/hummock/compactor_manager.rs 98.78% <ø> (-0.04%) ⬇️
src/meta/src/hummock/hummock_manager.rs 86.94% <ø> (-0.02%) ⬇️
src/meta/src/hummock/metrics_utils.rs 90.00% <ø> (-2.97%) ⬇️
src/meta/src/rpc/metrics.rs 68.26% <ø> (-12.44%) ⬇️
src/storage/src/hummock/compactor.rs 72.44% <100.00%> (+1.06%) ⬆️
src/storage/src/monitor/state_store_metrics.rs 85.06% <100.00%> (+2.37%) ⬆️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Little-Wallace Little-Wallace merged commit 558824a into main Jun 13, 2022
@Little-Wallace Little-Wallace deleted the wallace/metrics branch June 13, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants