-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: retry connect to meta until meta online #3165
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3165 +/- ##
==========================================
- Coverage 73.52% 73.51% -0.01%
==========================================
Files 739 739
Lines 101695 101710 +15
==========================================
+ Hits 74770 74771 +1
- Misses 26925 26939 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remembered that we have retry logic in Frontend/CN when connect to meta?
Nope, only the legacy Frontend does 😂. Currently, FE/CN will panic when meta is not online. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
BTW, I remember the purpose of moving these RPC interfaces into a separate crate is to implement a generic retry strategy for them. Any further idea on this? 🤣
Not really. 🤣 Well I'm not sure about this. NTFS. |
What's changed and what's your intention?
As title. This PR fixes #3065, but we still need to implement gRPC health check protocol mentioned in #41.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)
Resolve #3065 #295