Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(streaming): Fix error propagation in approx_count_distinct #3167

Merged
merged 2 commits into from
Jun 13, 2022
Merged

fix(streaming): Fix error propagation in approx_count_distinct #3167

merged 2 commits into from
Jun 13, 2022

Conversation

Graphcalibur
Copy link
Contributor

What's changed and what's your intention?

  • Change all instances of Result in approx_count_distinct to StreamExecutorResult
  • Allow for error propagation to the stream manager so that an error no longer crashes RisingWave

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/fix Bug fix label Jun 13, 2022
@Graphcalibur Graphcalibur requested a review from lmatz June 13, 2022 07:43
@Graphcalibur
Merge branch 'main' of https://github.com/singularity-data/risingwave …
d3f76a5 
…into steven/fix-approx-count-distinct-error
@Graphcalibur Graphcalibur merged commit 5da97cd into main Jun 13, 2022
@Graphcalibur Graphcalibur deleted the steven/fix-approx-count-distinct-error branch June 13, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmatz lmatz lmatz approved these changes

Assignees
No one assigned
Labels
type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Graphcalibur @lmatz