feat: add state for source manager #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabVersion <tabvision@bupt.icu>
Codecov Report
@@ Coverage Diff @@
## main #3170 +/- ##
==========================================
- Coverage 73.55% 73.52% -0.04%
==========================================
Files 736 736
Lines 101051 101206 +155
==========================================
+ Hits 74326 74409 +83
- Misses 26725 26797 +72
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
yezizp2012
reviewed
Jun 13, 2022
| @@ -623,9 +612,32 @@ where | |||
| /// Dropping materialized view is done by barrier manager. Check | |||
| /// [`Command::DropMaterializedView`] for details. | |||
| pub async fn drop_materialized_view(&self, table_id: &TableId) -> Result<()> { | |||
| let table_fragments = self | |||
There was a problem hiding this comment.
Can we get source_fragments directly from a new interface inside FragmentManager? 🤔
There was a problem hiding this comment.
It doesn't seem to work, the table fragments are passed in as external parameters when creating materialized view, fetch_source_fragments is already the maximum level of abstraction
yezizp2012
reviewed
Jun 13, 2022
| self.barrier_manager | ||
| .run_command(Command::DropMaterializedView(*table_id)) | ||
| .await?; | ||
|
|
||
| let mut actor_ids = HashSet::new(); |
There was a problem hiding this comment.
Using Default::default here would make it impossible to derive the type
Signed-off-by: Peng Chen <peng@singularity-data.com>
tabVersion
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
as title
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)