Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(front): use no column for pk of simple agg #3185

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Jun 13, 2022

What's changed and what's your intention?

Surprised that nothing breaks down in the backend... 馃槻

Checklist

- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests

  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

closes #3120

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3185 (8371a6b) into main (e7c8e95) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3185      +/-   ##
==========================================
- Coverage   73.60%   73.60%   -0.01%     
==========================================
  Files         744      744              
  Lines      102025   102025              
==========================================
- Hits        75092    75091       -1     
- Misses      26933    26934       +1     
Flag Coverage 螖
rust 73.60% <100.00%> (-0.01%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 97.86% <100.00%> (酶)
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) 猬囷笍

馃摚 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lmatz lmatz marked this pull request as ready for review June 14, 2022 02:06
@lmatz lmatz requested review from skyzh and xiangjinwu and removed request for skyzh June 14, 2022 03:53
Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool 馃い馃い馃い

@lmatz lmatz merged commit 61886cb into main Jun 14, 2022
@lmatz lmatz deleted the lz/pk_simple branch June 14, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimizer: remove pk from simple agg
2 participants