Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix in-correct unittest (pk infer) #3192

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Conversation

BowenXiao1999
Copy link
Contributor

@BowenXiao1999 BowenXiao1999 commented Jun 14, 2022

What's changed and what's your intention?

The source has pk vec![2]. So the agg should accept pk_indices as vec![2].

The unitest is wrong-written.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/fix Bug fix label Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #3192 (c827d41) into main (921fc59) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3192   +/-   ##
=======================================
  Coverage   73.58%   73.58%           
=======================================
  Files         744      744           
  Lines      102198   102198           
=======================================
+ Hits        75200    75203    +3     
+ Misses      26998    26995    -3     
Flag Coverage Δ
rust 73.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/global_simple_agg.rs 96.08% <100.00%> (ø)
src/stream/src/executor/hash_agg.rs 97.62% <100.00%> (ø)
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️
src/stream/src/executor/aggregation/mod.rs 95.73% <0.00%> (+0.77%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BowenXiao1999 BowenXiao1999 merged commit d8ea000 into main Jun 14, 2022
@BowenXiao1999 BowenXiao1999 deleted the bw/fix-in-correct-ut branch June 14, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants