refactor(state_table): pre-compute column id mapping #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #3201 +/- ##
==========================================
- Coverage 73.56% 73.55% -0.01%
==========================================
Files 745 745
Lines 102223 102242 +19
==========================================
+ Hits 75199 75208 +9
- Misses 27024 27034 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
lmatz
approved these changes
Jun 14, 2022
BugenZhao
approved these changes
Jun 14, 2022
| @@ -88,7 +116,7 @@ impl CellBasedRowDeserializer { | |||
| pub fn take(&mut self) -> Option<(Vec<u8>, Row)> { | |||
| let cur_pk_bytes = self.pk_bytes.take(); | |||
| cur_pk_bytes.map(|bytes| { | |||
| let ret = self.data.iter_mut().map(Option::take).collect::<Vec<_>>(); | |||
| let ret = std::mem::replace(&mut self.data, vec![None; self.columns.len()]); | |||
There was a problem hiding this comment.
Will this lead to extra allocation?
There was a problem hiding this comment.
I believe no. Previously, .collect_vec() will lead to one allocation. Now only vec![None; self.columns.len()] has one allocation.
Comment on lines
-196
to
+210
| #[allow(dead_code)] | ||
| pub async fn get<'a, 'b>(&'a mut self, key: &'b K) -> Option<&'a HashValueType<S>> { | ||
| let state = self.inner.get(key); | ||
| // TODO: we should probably implement a entry function for `LruCache` | ||
| match state { | ||
| Some(_) => self.inner.get(key), | ||
| None => { | ||
| let remote_state = self.fetch_cached_state(key).await.unwrap(); | ||
| remote_state.map(|rv| { | ||
| self.inner.put(key.clone(), rv); | ||
| self.inner.get(key).unwrap() | ||
| }) | ||
| } | ||
| } | ||
| } | ||
| // #[allow(dead_code)] | ||
| // pub async fn get<'a, 'b>(&'a mut self, key: &'b K) -> Option<&'a HashValueType<S>> { | ||
| // let state = self.inner.get(key); | ||
| // // TODO: we should probably implement a entry function for `LruCache` | ||
| // match state { | ||
| // Some(_) => self.inner.get(key), | ||
| // None => { | ||
| // let remote_state = self.fetch_cached_state(key).await.unwrap(); | ||
| // remote_state.map(|rv| { | ||
| // self.inner.put(key.clone(), rv); | ||
| // self.inner.get(key).unwrap() | ||
| // }) | ||
| // } | ||
| // } | ||
| // } |
There was a problem hiding this comment.
It's not used. And it triggers Rust compiler's false negative very often. So I commented it out. Anyone needs this can simply revert the comment.
wcy-fdu
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Chi iskyzh@gmail.com
What's changed and what's your intention?
As title
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)