Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): support deterministic datagen for random int/float #3207

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

tabVersion
Copy link
Contributor

Signed-off-by: tabVersion tabvision@bupt.icu

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

int and float generation supports deterministic results with given seed and offset (we xor seed and offset as new seed).

the prev impl gen a certain sequence with the given seed, but if we rebuild the source, datagen will output the sequence from the beginning rather than at the specific offset.

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
    • varchar and timestamp datagen does not support deterministic gen
  • Add the 'user-facing changes' label if your PR contains changes that are visible to users (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

helps #3039

Signed-off-by: tabVersion <tabvision@bupt.icu>
@tabVersion tabVersion requested a review from shanicky June 14, 2022 07:58
@github-actions github-actions bot added the type/fix Bug fix label Jun 14, 2022
Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabVersion tabVersion enabled auto-merge (squash) June 14, 2022 08:03
@tabVersion tabVersion merged commit 1e674b9 into main Jun 14, 2022
@tabVersion tabVersion deleted the tab/fix-datagen-state branch June 14, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants