Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cell_based_table): rename iter_with_pk to dedup_pk_iter #3209

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Jun 14, 2022

What's changed and what's your intention?

See: #3203 (comment)

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
  • Add the 'user-facing changes' label if your PR contains changes that are visible to users (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

related #3203

@kwannoel kwannoel enabled auto-merge (squash) June 14, 2022 08:28
Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also use Rust doc string on the function to tell about what this function do. e.g.

/// pk_dedup_iter should be used when pk is not persisted as value in storage. It will attempt to decode pk from key instead of cell value. Tracking issue: .

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #3209 (cad1bff) into main (c86f7e2) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #3209   +/-   ##
=======================================
  Coverage   73.57%   73.57%           
=======================================
  Files         745      745           
  Lines      102290   102290           
=======================================
  Hits        75263    75263           
  Misses      27027    27027           
Flag Coverage Δ
rust 73.57% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/row_seq_scan.rs 23.27% <0.00%> (ø)
src/stream/src/executor/batch_query.rs 91.42% <ø> (ø)
src/storage/src/table/cell_based_table.rs 71.30% <100.00%> (ø)
src/storage/src/table/test_relational_table.rs 98.22% <100.00%> (ø)
src/meta/src/barrier/mod.rs 69.13% <0.00%> (-0.33%) ⬇️
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@kwannoel kwannoel disabled auto-merge June 14, 2022 08:37
@kwannoel kwannoel enabled auto-merge (squash) June 14, 2022 08:45
@kwannoel kwannoel merged commit ad2911d into main Jun 14, 2022
@kwannoel kwannoel deleted the kwannoel/naming-dedup-pk branch June 14, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants