Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce rpc error #3211

Merged
merged 2 commits into from
Jun 14, 2022
Merged

chore: introduce rpc error #3211

merged 2 commits into from
Jun 14, 2022

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Jun 14, 2022

What's changed and what's your intention?

As title.

We should always use the wrapper functions in rpc_client crate in the future. We may store some info about the worker nodes there and refine the error messages.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️

Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSTM.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #3211 (09a158b) into main (1b5fe56) will increase coverage by 0.01%.
The diff coverage is 30.66%.

@@            Coverage Diff             @@
##             main    #3211      +/-   ##
==========================================
+ Coverage   73.56%   73.57%   +0.01%     
==========================================
  Files         745      746       +1     
  Lines      102223   102191      -32     
==========================================
- Hits        75199    75190       -9     
+ Misses      27024    27001      -23     
Flag Coverage Δ
rust 73.57% <30.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/error.rs 64.81% <0.00%> (-1.36%) ⬇️
src/frontend/src/handler/dml.rs 0.00% <0.00%> (ø)
src/frontend/src/meta_client.rs 0.00% <ø> (ø)
...rontend/src/scheduler/distributed/query_manager.rs 11.32% <0.00%> (+0.20%) ⬆️
src/frontend/src/scheduler/error.rs 0.00% <ø> (ø)
src/frontend/src/test_utils.rs 92.30% <0.00%> (ø)
src/meta/src/barrier/recovery.rs 0.00% <0.00%> (ø)
src/meta/src/stream/source_manager.rs 27.81% <0.00%> (ø)
src/rpc_client/src/compute_client_pool.rs 41.66% <0.00%> (+8.33%) ⬆️
src/rpc_client/src/lib.rs 100.00% <ø> (ø)
... and 13 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BugenZhao BugenZhao merged commit a4aab7a into main Jun 14, 2022
@BugenZhao BugenZhao deleted the bz/introduce-rpc-error branch June 14, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants